Minor: Add tests for types of arithmetic operator output types #14250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While reviewing #14223 I misinterpreted the impact of a change.
@jonahgao straightened me out in https://github.com/apache/datafusion/pull/14223/files#r1926245243 and had a good suggestion of how to test the behavior (don't overly extend the output types)
So let's add some tests to automatically ensure the coercion is working correctly
What changes are included in this PR?
Add tests that show the output type of arithmetic operations with different input types
Are these changes tested?
It is only tests, no behavior change
Are there any user-facing changes?